scripts/tools/logger.js (1)

1-19: Consider adjusting the formatting to meet Prettier style requirements.

According to the static analysis hints, the file should avoid multiline bracket formatting in lines 5-8 and 11-14 and remove the trailing comma on line 16. Implementing these suggestions will keep the codebase consistent.

Here is a potential diff to adjust the formatting:

 const logger = createLogger({
   level: 'error', // minimum level
-  format: format.combine(
-    format.timestamp(),
-    format.json()
-  ),
+  format: format.combine(format.timestamp(), format.json()),
   transports: [
     new transports.Console({
-      format: format.combine(
-        format.colorize(),
-        format.simple()
-      )
+      format: format.combine(format.colorize(), format.simple())
     })
-  ],
+  ]
 });

🧰 Tools

🪛 eslint

[error] 5-8: Replace ⏎····format.timestamp(),⏎····format.json()⏎·· with format.timestamp(),·format.json()

(prettier/prettier)

---

[error] 11-14: Replace ⏎········format.colorize(),⏎········format.simple()⏎······ with format.colorize(),·format.simple()

(prettier/prettier)

---

[error] 16-16: Delete ,

(prettier/prettier)

---

[error] 19-19: Insert ⏎

(prettier/prettier)

tests/build-pages.test.js (2)

26-32: Use arrow function parentheses for clarity.

For the callback in [TEST_DIR, NEW_TEST_DIR].forEach(dir => { ... }), consider adding parentheses around the parameter for readability. This aligns with Prettier’s recommended styling.

-[TEST_DIR, NEW_TEST_DIR].forEach(dir => {
+[TEST_DIR, NEW_TEST_DIR].forEach((dir) => {

🧰 Tools

🪛 eslint

[error] 26-27: Replace ⏎····[TEST_DIR,·NEW_TEST_DIR].forEach(dir with ····[TEST_DIR,·NEW_TEST_DIR].forEach((dir)

(prettier/prettier)

---

44-50: Similarly apply arrow function parentheses.

We can mirror the same style in the afterAll callback for consistency.

🧰 Tools

🪛 eslint

[error] 44-45: Replace ⏎····[TEST_DIR,·NEW_TEST_DIR].forEach(dir with ····[TEST_DIR,·NEW_TEST_DIR].forEach((dir)

(prettier/prettier)

---

[error] 50-50: Delete ····

(prettier/prettier)

scripts/tools/tools-object.js (1)

11-11: Replace ".js" extension for consistency.

The static analysis suggests avoiding explicit file extensions. Using './logger' instead of './logger.js' is an option if the codebase style allows it.

-const logger = require("./logger.js");
+const logger = require("./logger");

🧰 Tools

🪛 eslint

[error] 11-11: Replace "./logger.js" with './logger.js'

(prettier/prettier)

---

[error] 11-11: Unexpected use of file extension "js" for "./logger.js"

(import/extensions)

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

scripts/tools/logger.js (1)

3-11: Consider enhancing logger configuration for better observability

The Winston logger setup implements good practices with structured logging (JSON format + timestamp). However, consider these enhancements:

1. The 'error' level might miss important warnings. Consider using 'info' as the base level and filtering at the transport level.
2. Add file transport for persistent logging in production.

 const logger = createLogger({
-  level: 'error', // minimum level of messages logger will handle
+  level: 'info', // capture all important logs
   format: format.combine(format.timestamp(), format.json()),
   transports: [
     new transports.Console({
+      level: 'error', // filter console output to errors
       format: format.combine(format.colorize(), format.simple())
-    })
+    }),
+    new transports.File({
+      filename: 'error.log',
+      level: 'error',
+      format: format.combine(
+        format.timestamp(),
+        format.json()
+      )
+    })
   ]
 });

scripts/tools/tools-object.js (2)

11-11: Fix quote consistency

Use single quotes consistently across the file.

-const logger = require("./logger");
+const logger = require('./logger');

🧰 Tools

🪛 eslint

[error] 11-11: Replace "./logger" with './logger'

(prettier/prettier)

---

Line range hint 89-91: Standardize error handling approach

The nested try-catch blocks have inconsistent error handling approaches. The inner catch throws directly while the outer catch logs and wraps. Consider standardizing the approach.

      } catch (err) {
-       console.error(err)
-       throw err;
+       logger.error('Error processing individual tool', {
+         message: err.message,
+         stack: err.stack,
+         phase: 'individual_tool_processing',
+       });
+       throw new Error(`Error processing individual tool: ${err.message}`);
      }
    }))
    
    return finalToolsObject;
  } catch (err) {
    logger.error('Error processing tool', {
      message: err.message,
      stack: err.stack,
      phase: 'tool_processing',
    });
    throw new Error(`Error processing tool: ${err.message}`)
  }

Also applies to: 111-120

🧰 Tools

🪛 eslint

[error] 8-8: Replace "uri"]) with 'uri']);

(prettier/prettier)

---

[error] 9-9: Insert ;

(prettier/prettier)

---

[error] 11-11: Replace "./logger" with './logger'

(prettier/prettier)

tests/build-pages.test.js (1)

27-31: Optimize test cleanup code

The directory cleanup logic is duplicated in beforeAll and afterAll. Consider extracting it to a helper function.

+const cleanupTestDirs = () => {
+  [TEST_DIR, NEW_TEST_DIR].forEach((dir) => {
+    if (fs.existsSync(dir)) {
+      fs.rmSync(dir, { recursive: true, force: true });
+    }
+  });
+};

 beforeAll(() => {
-  [TEST_DIR, NEW_TEST_DIR].forEach((dir) => {
-    if (fs.existsSync(dir)) {
-      fs.rmSync(dir, { recursive: true, force: true });
-    }
-  });
+  cleanupTestDirs();
   // ... rest of setup
 });

 afterAll(() => {
-  [TEST_DIR, NEW_TEST_DIR].forEach(dir => {
-    if (fs.existsSync(dir)) {
-      fs.rmSync(dir, { recursive: true, force: true });
-    }
-  });
+  cleanupTestDirs();
 });

Also applies to: 45-49

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

tests/build-pages.test.js (1)

66-68: ⚠️ Potential issue

Handle potential race condition in directory check.

The existence check and directory creation are not atomic operations.

Based on the past review comments and your response about test failures, let's try a different approach that maintains the test's expectations while being more robust:

-    if (fs.existsSync(NEW_TEST_DIR)) {
-      fs.rmSync(NEW_TEST_DIR, { recursive: true, force: true });
-    }
+    try {
+      fs.rmSync(NEW_TEST_DIR, { recursive: true, force: true });
+    } catch (err) {
+      if (err.code !== 'ENOENT') {
+        throw err;
+      }
+    }

scripts/tools/logger.js (1)

3-11: Consider enhancing logger configuration for production use.

The current logger configuration could be improved for production environments:

1. Consider adding file transport for persistent logging
2. Add log rotation to manage log file sizes
3. Make log level configurable via environment variables

Here's a suggested enhancement:

 const logger = createLogger({
-  level: 'error', // minimum level of messages logger will handle
+  level: process.env.LOG_LEVEL || 'error',
   format: format.combine(format.timestamp(), format.json()),
   transports: [
     new transports.Console({
       format: format.combine(format.colorize(), format.simple())
-    })
+    }),
+    new transports.File({
+      filename: 'error.log',
+      level: 'error',
+      maxsize: 5242880, // 5MB
+      maxFiles: 5,
+      format: format.combine(
+        format.timestamp(),
+        format.json()
+      )
+    })
   ]
 });

tests/build-pages.test.js (1)

27-31: Simplify directory cleanup logic.

The directory cleanup logic is duplicated in beforeAll and afterAll hooks. Consider extracting it to a helper function.

+const cleanupTestDirs = (dirs) => {
+  dirs.forEach((dir) => {
+    if (fs.existsSync(dir)) {
+      fs.rmSync(dir, { recursive: true, force: true });
+    }
+  });
+};
+
 beforeAll(() => {
-  [TEST_DIR, NEW_TEST_DIR].forEach((dir) => {
-    if (fs.existsSync(dir)) {
-      fs.rmSync(dir, { recursive: true, force: true });
-    }
-  });
+  cleanupTestDirs([TEST_DIR, NEW_TEST_DIR]);

scripts/tools/tools-object.js (1)

114-118: Enhance error logging with additional context.

The error logging could be more informative by including additional context about the tool being processed.

-    logger.error('Error processing tool', {
+    logger.error('Failed to process tool', {
       message: err.message,
       stack: err.stack,
+      toolName: tool?.name,
+      repositoryUrl: tool?.repository?.html_url,
       phase: 'tool_processing',
     });

🧰 Tools

🪛 eslint

[error] 117-117: Delete ,

(prettier/prettier)

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro